Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how the trial energy is updated. #4488

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Document how the trial energy is updated. #4488

merged 2 commits into from
Mar 1, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Feb 28, 2023 •
edited
Loading

Proposed changes

Necessary info must be exposed to users.

What type(s) of changes does this code introduce?

  • Documentation changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo ye-luo changed the title [WIP] Document how the trial energy is updated. Document how the trial energy is updated. Feb 28, 2023
prckent
prckent approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One less undocumented algorithm.

@prckent
Copy link
Contributor

prckent commented Mar 1, 2023

Test this please

@prckent prckent enabled auto-merge March 1, 2023 14:56
@prckent prckent merged commit c06be73 into QMCPACK:develop Mar 1, 2023
@prckent prckent mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent